[release-10.2.1] Do not allow to set higher permissions on a public link share for a resource which was shared with limited permissions

[DeepDiver1975]

…share-update-test

Do not allow to set higher permissions on a public link share for a r…

backport #35585

[phil-davis]

There was 1 error:

1) OCA\Files_Sharing\Tests\API\Share20OcsControllerTest::testUpdateLinkHigherPermissions
Error: Class 'OCA\Files_Sharing\Tests\API\ILockingProvider' not found

/drone/src/apps/files_sharing/tests/Controller/Share20OcsControllerTest.php:1675

--

https://drone.owncloud.com/owncloud/core/18582/134
same problem as in stable10 backport

[codecov]

Codecov Report

Merging #35600 into release-10.2.1 will decrease coverage by 18.97%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             release-10.2.1   #35600       +/-   ##
=====================================================
- Coverage             64.39%   45.41%   -18.98%     
=====================================================
  Files                  1286      116     -1170     
  Lines                 77078    11577    -65501     
  Branches               1308     1308               
=====================================================
- Hits                  49631     5258    -44373     
+ Misses                27063     5935    -21128     
  Partials                384      384

Flag	Coverage Δ	Complexity Δ
#javascript	53.66% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	30.81% <ø> (-34.72%)	0 <ø> (-20140)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1160 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc2883...4906da2. Read the comment docs.

[codecov]

Codecov Report

Merging #35600 into release-10.2.1 will increase coverage by <.01%.
The diff coverage is 100%.

@@                 Coverage Diff                  @@
##             release-10.2.1   #35600      +/-   ##
====================================================
+ Coverage             64.39%   64.39%   +<.01%     
- Complexity            20145    20147       +2     
====================================================
  Files                  1286     1286              
  Lines                 77087    77092       +5     
  Branches               1308     1308              
====================================================
+ Hits                  49640    49645       +5     
  Misses                27063    27063              
  Partials                384      384

Flag	Coverage Δ	Complexity Δ
#javascript	53.66% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.53% <100%> (ø)	20147 <0> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php	87.52% <100%> (+0.1%)	211 <0> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1d126...46371fd. Read the comment docs.

[phil-davis]

Random CI error https://drone.owncloud.com/owncloud/core/18598/835

  [Composer\Downloader\TransportException]                                                                                                                                      
The "https://packagist.org/p/provider-2019-01%2466c13dcadb7dfc0f152e52dd4df42e53df7c374618eaa2680f41d8667ce54b12.json" file could not be downloaded (HTTP/1.1 404 Not Found) 

I will trigger CI again.

[davitol]

The solution provided by this PR is a warning that appears and prevents the creation of a public link share for a resource which was shared with limited permissions. But IMHO the best approach should be do not show that option (Download/View/Edit) option in the webUI if we do not have permissions.

Any thoughts? @DeepDiver1975 @pmaier1 @patrickjahns