Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Do not allow to set higher permissions on a public link share for a resource which was shared with limited permissions #35599

Merged

Conversation

DeepDiver1975
Copy link
Member

…update-test

Do not allow to set higher permissions on a public link share for a r…

backport #35585

@patrickjahns patrickjahns changed the title [stable10] Merge pull request #35585 from owncloud/bugfix/link-share-… [stable10] Do not allow to set higher permissions on a public link share for a resource which was shared with limited permissions Jun 19, 2019
@patrickjahns patrickjahns added this to the development milestone Jun 19, 2019
@phil-davis
Copy link
Contributor

There was 1 error:

1) OCA\Files_Sharing\Tests\API\Share20OcsControllerTest::testUpdateLinkHigherPermissions
Error: Class 'OCA\Files_Sharing\Tests\API\ILockingProvider' not found

/drone/src/apps/files_sharing/tests/Controller/Share20OcsControllerTest.php:1675

https://drone.owncloud.com/owncloud/core/18578/134

Some unit test adjustments needed for stable10 ?

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable10@4825236). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35599   +/-   ##
===========================================
  Coverage            ?   64.82%           
  Complexity          ?    20213           
===========================================
  Files               ?     1294           
  Lines               ?    77272           
  Branches            ?     1301           
===========================================
  Hits                ?    50089           
  Misses              ?    26798           
  Partials            ?      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.97% <100%> (?) 20213 <0> (?)
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.52% <100%> (ø) 211 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4825236...9c8d964. Read the comment docs.

@phil-davis
Copy link
Contributor

random CI error https://drone.owncloud.com/owncloud/core/18602/981

  [Composer\Downloader\TransportException]                                                                                                                                      
The "https://packagist.org/p/provider-2018-10%2471c16c8fe02eae14b1ea42b70311ce31afee933b1103644b34314b310264a4a6.json" file could not be downloaded (HTTP/1.1 404 Not Found) 

I will trigger CI again.

@phil-davis phil-davis force-pushed the stable10-bfa66f7b146eb7fa9299984494cbea8a5def3ff7 branch from be378b0 to 9c8d964 Compare June 20, 2019 08:03
@phil-davis
Copy link
Contributor

More CI crap

 The "https://packagist.org/p/paragonie/random_compat%244bc758254ff6e8d91a86a1becfc231f995435a640d96315b0c1baf5f1e000684.json" file could not be downloaded (HTTP/1.1 404 Not Found) 

https://drone.owncloud.com/owncloud/core/18624/108

These packagist 404's are getting more frequent.

Restarting CI...

…update-test

Do not allow to set higher permissions on a public link share for a r…
@phil-davis phil-davis force-pushed the stable10-bfa66f7b146eb7fa9299984494cbea8a5def3ff7 branch from 9c8d964 to 006e0b0 Compare June 20, 2019 12:12
@phil-davis phil-davis merged commit 56a20fc into stable10 Jun 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-bfa66f7b146eb7fa9299984494cbea8a5def3ff7 branch June 20, 2019 14:19
@phil-davis
Copy link
Contributor

Note: PR for relese-10.2.1 is #35600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants