[stable9] Fix default quota #28302
Merged
[stable9] Fix default quota #28302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2017 10:51
User::getQuota() and User::setQuota() are now reading the exact value as set in the database instead of interpreting it. This is how it used to behave. Util::getUserQuota() is the method that interprets the quota for example by replacing a default value with the default quota value from the app config.
jvillafanez
reviewed
Jul 5, 2017
| if ($userQuota === null || $userQuota === 'default') { | ||
| $userQuota = \OC::$server->getConfig()->getAppValue('files', 'default_quota', 'none'); | ||
| } | ||
| if ($userQuota === null || $userQuota === 'none') { |
There was a problem hiding this comment.
$userQuota === null won't happen ever I think. Not a big deal anyway.
There was a problem hiding this comment.
hmm indeed, missed that in the original port (might even have been part of the original code I reverted)
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27896 to stable9
Supersedes #27957
Please review @DeepDiver1975 @jvillafanez @Gomez
TODO: manual retest: