[stable9.0] Proper separation of quota values in APIs

[Gomez]

Backport of #27896

Fixes: #27608

[PVince81]

Thanks. If you tested all scenarios I listed in the original ticket, please post them here

[DeepDiver1975]

[Gomez]

Same unit errors as here #27895 (comment) cant spot the difference. Any help appreciated.

Tests done:

Set default quota to 5 GB

• TEST: newly created user gets "default" quota, properly applies in personal page, 5 GB
• TEST: set existing user quota to "default", properly applies in personal page, 5 GB
• TEST: set existing user quota to "unlimited", properly applies in personal page (unlimited)
• TEST: set existing user quota to "1 GB", properly applies in personal page, 1 GB

[PVince81]

Indeed, the patch is the same like stable9.1...

[PVince81]

running all the tests locally do not reproduce this issue... classic.

And running the versions suite alone gives me weird errors:

...FF....F......E...                                              20 / 20 (100%)

Time: 1.23 seconds, Memory: 33.50MB

There was 1 error:

1) Test_Files_Versioning::testRestoreNoPermission
Exception: The share API is disabled

/srv/www/htdocs/owncloud/lib/private/share20/manager.php:486
/srv/www/htdocs/owncloud/lib/private/share20/manager.php:504
/srv/www/htdocs/owncloud/apps/files_versions/tests/versions.php:631

welcome to weirdland

[PVince81]

okay, seems I got it with phpunit 4.4.5:

11) Test_Files_Versioning::testRename
Failed asserting that false is true.

/srv/www/htdocs/owncloud/apps/files_versions/tests/versions.php:290

12) Test_Files_Versioning::testRenameInSharedFolder
Failed asserting that false is true.

/srv/www/htdocs/owncloud/apps/files_versions/tests/versions.php:333

13) Test_Files_Versioning::testCopy
Failed asserting that false is true.

/srv/www/htdocs/owncloud/apps/files_versions/tests/versions.php:532

why 11) ? well, locally there are some tests that always failed for me (testGetThumbnail: your test is not allowed to access the database), never had time to look into these...

[PVince81]

Apparently the quota returned in OCA\Files_Versions\Storage is "default" but the code passes this to computerFileSize which converts it to 0. I'll try and fix this, seems something is missing here.

[PVince81]

ah yes of course, you're missing a lot of the code from the original stable9.1 PR, like f5734c0#diff-efc44835a2c59b3707c965b80a3d669e

[PVince81]

I'm going to redo the backport from scratch, just in case

[PVince81]

protip: to backport to stable9, create patches with git format-patch, then edit the patches, lower case the file names, remove "test" suffixes. Then use git am -3 patch.patch to apply.

[PVince81]

new PR: #28302

[Gomez]

Thanks @PVince81 for redo and the protip !

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.