a single token provider suffices #24677
Conversation
ChristophWurst
force-pushed
the
single-token-provider
branch
from
49fc06f
to
224a66d
Compare
| * | ||
| * @return string | ||
| */ | ||
| public function getPassword() { |
There was a problem hiding this comment.
Why add this if you are only calling the parent?
There was a problem hiding this comment.
Because it's part of the IToken interface and if I remember correctly it doesn't work with the magic method of the Entity class. The parent method is a magic getter.
There was a problem hiding this comment.
Correct. I also noticed this :(
There was a problem hiding this comment.
aaah yes crappy magic functions...
|
Yes things like that happen during development! Also... intergration tests are failing |
ChristophWurst
force-pushed
the
single-token-provider
branch
from
224a66d
to
98b465a
Compare
fixed. Thanks for the quick review \o/ |
|
👍 as discussed However I'm surprised that going from multi to single require all these interface additions ? Are they related or is that bonus content ? |
Those changes enforce the 'program to an interface, not an implementation' principle. Before the |
|
Sounds good! |
|
Code makes sense and it still works 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When implementing pluggable auth I thought we need it, but now I realized this makes things more complex as we won't need multiple providers.
@LukasReschke objections?
@MorrisJobke @PVince81 @rullzer review please