Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow token login for disabled users #24660

Merged
merged 1 commit into from
May 19, 2016
Merged

don't allow token login for disabled users #24660

merged 1 commit into from
May 19, 2016

Conversation

ChristophWurst
Copy link
Contributor

Steps to reproduce the bug/test the fix:

  1. generate a device specific token (POST localhost:8080/token/generate?user=yourusername&password=yourpassword)
  2. use that token to access a OCS API (e.g. GET http://localhost:8080/ocs/v1.php/apps/files_sharing/api/v1/sharees?format=json&search=a&perPage=200&itemType=folder with header Authorization: token xxxxxxxxxxxxxx
  3. get access or not depending on which branch is used

@ChristophWurst ChristophWurst added this to the 9.1-current milestone May 17, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @icewind1991, @blizzz and @DeepDiver1975 to be potential reviewers

@rullzer
Copy link
Contributor

rullzer commented May 17, 2016

Can we have unit tests?

@ChristophWurst
Copy link
Contributor Author

requires #24677

@MorrisJobke
Copy link
Contributor

requires #24677

Is merged now

@ChristophWurst ChristophWurst force-pushed the no-token-login-for-disabled-users branch from c32d69f to f824f3e Compare May 18, 2016 19:09
@ChristophWurst
Copy link
Contributor Author

Unit test added. Please review @rullzer @MorrisJobke

@PVince81
Copy link
Contributor

Makes sense 👍

@rullzer
Copy link
Contributor

rullzer commented May 19, 2016

👍

@PVince81 PVince81 merged commit 3b3940d into master May 19, 2016
@PVince81 PVince81 deleted the no-token-login-for-disabled-users branch May 19, 2016 13:32
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - To release comp:authentication security Type:Bug
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @mention-bot @rullzer @MorrisJobke @PVince81