introduce alt text for rename icon - fixes #12067 #12688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged first #12394 ? |
|
@MorrisJobke rebase please |
|
I know ... that's the reason I changed the label ;) |
MorrisJobke
force-pushed
the
rename-alt
branch
from
64611ff
to
1bfa405
Compare
|
Updated. Complete new approach. @PVince81 Is this a possible and valid solution or too hacky? |
|
I can also add parameters to fil the alt test right inside |
|
Looks good 👍 |
|
The inspection completed: No new issues |
|
🚀 Test PASSed. 🚀 |
|
@LukasReschke easy review one ;) |
|
👍 |
LukasReschke
added a commit
that referenced
this pull request
Dec 9, 2014
introduce alt text for rename icon - fixes #12067
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But there is no little tooltip that indicates that this means "rename" (even not a tooltip from browser - tested with FF and Chrome)
fixes #12067
cc @owncloud/designers