Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Need alt text on Rename icon #12067

Closed
jancborchardt opened this issue Nov 10, 2014 · 3 comments · Fixed by #12688
Closed

Accessibility: Need alt text on Rename icon #12067

jancborchardt opened this issue Nov 10, 2014 · 3 comments · Fixed by #12688
Labels
3 - To Review app:files design enhancement
Milestone
8.0

Comments

@jancborchardt
Copy link
Member

We need to put an alt text on the rename icon since it doesn’t have the action text next to it, or a title.
We could also do it like for the delete icon and use a tipsy tooltip, but I think that’s overkill.

An empty alt tag will be introduced via af743ef
We need to make sure that the other actions (Download, Share, Delete etc) do not get alt text, since then the text would be duplicated. This is really only necessary for the Rename icon.

cc @PVince81
@jancborchardt jancborchardt added this to the 2014-sprint-08-next milestone Nov 10, 2014
@jancborchardt jancborchardt mentioned this issue Nov 10, 2014
Merged
@PVince81
Copy link
Contributor

Wrongly closed by a reference in the PR, reopening.

@PVince81 PVince81 reopened this Nov 10, 2014
@craigpg craigpg modified the milestones: 2014-sprint-09-next, 2014-sprint-08-current Nov 10, 2014
@jancborchardt
Copy link
Member Author

cc @owncloud/designers

@jancborchardt jancborchardt mentioned this issue Nov 16, 2014
Closed
@MorrisJobke MorrisJobke self-assigned this Nov 16, 2014
@MorrisJobke MorrisJobke mentioned this issue Dec 8, 2014
Merged
@MorrisJobke MorrisJobke modified the milestones: 8.0-current, 2014-sprint-09-next Dec 8, 2014
MorrisJobke added a commit that referenced this issue Dec 8, 2014
@MorrisJobke
introduce alt text for rename icon - fixes #12067
1bfa405
LukasReschke added a commit that referenced this issue Dec 9, 2014
@LukasReschke
Merge pull request #12688 from owncloud/rename-alt
17f85ec 
introduce alt text for rename icon - fixes #12067
@MorrisJobke
Copy link
Contributor

will be fixed in OC8

@MorrisJobke MorrisJobke removed their assignment Oct 5, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - To Review app:files design enhancement
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

introduce alt text for rename icon - fixes #12067 owncloud/core
4 participants
@craigpg @MorrisJobke @PVince81 @jancborchardt