Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add text labels to bottom nav bar #4498

Merged

Conversation

Yogeshjindal
Copy link
Contributor

Added text labels to the bottom nav bar
Used default activeStateIndicator which will show which label is selected

Now, all the items in nav bar shows the labels and upon selection the activeIndicator is enabled which shows that which item is selected.
Fix#4484

@JuancaG05
Copy link
Collaborator

Hi @Yogeshjindal! Commits here keep not following conventional commits. They should be named like this:
feat: add text labels in bottom bar
chore: added calens file
Also, as I reported in the previous PR, don't mention the active indicator in release notes or Calens file, you didn't actually modify it.
This branch needs a rebase against master, otherwise we won't be able to merge it.
Other than that, everything is good! 👍

@JuancaG05 JuancaG05 linked an issue Oct 16, 2024 that may be closed by this pull request
@Yogeshjindal Yogeshjindal force-pushed the feature/add-text-labels-bottom-bar branch from 17c1fd0 to 40de9c2 Compare October 17, 2024 04:04
@Yogeshjindal Yogeshjindal force-pushed the feature/add-text-labels-bottom-bar branch from 4797e68 to f27fc55 Compare October 17, 2024 04:07
@JuancaG05 JuancaG05 self-requested a review October 17, 2024 06:36
@JuancaG05 JuancaG05 changed the title feat(bottom-nav-bar): Add text labels and active indicator [FEATURE REQUEST] Add text labels to bottom nav bar Oct 17, 2024
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This is great now!! 💯
Approved on my side! Thanks for the work and effort here @Yogeshjindal 🥇
Let's move this to QA

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Oct 17, 2024

This time I'll do the QA myself

Checks:
1. oCIS:

  • Bottom bar looking (both orientations)
  • Navigating between sections changes the active indicator
  • Changing the device orientation keeps the bottom bar in the same status

2. oC10:

  • Bottom bar looking (both orientations)
  • Navigating between sections changes the active indicator
  • Changing the device orientation keeps the bottom bar in the same status

@JuancaG05
Copy link
Collaborator

Approved by QA! 🚀

@JuancaG05 JuancaG05 merged commit 5b4bc56 into owncloud:master Oct 17, 2024
4 checks passed
@tbsbdr
Copy link

tbsbdr commented Oct 17, 2024

🎻cant wait to see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add text labels to bottom nav bar
3 participants