feat: add text labels in bottom bar

owncloud · Oct 17, 2024 · 40de9c2 · 40de9c2
1 parent dcf82f2
commit 40de9c2
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/changelog/unreleased/4484 b/changelog/unreleased/4484
@@ -0,0 +1,7 @@
+Enhancement: Added text labels for BottomNavigationView
+
+Text labels have been added below the icons, and the active indicator feature is implemented using the default itemActiveIndicatorStyle for better navigation experience.
+
+
+https://github.com/owncloud/android/issues/4484
+https://github.com/owncloud/android/pull/4497
diff --git a/...App/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt b/...App/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt
@@ -50,6 +50,11 @@ class ReleaseNotesViewModel(
                 subtitle = R.string.release_notes_bugfixes_subtitle,
                 type = ReleaseNoteType.BUGFIX
             ),
+            ReleaseNote(
+                title = R.string.release_notes_title_enhanced_bottom_nav_bar,
+                subtitle = R.string.release_notes_subtitle_bottom_nav_bar,
+                type = ReleaseNoteType.ENHANCEMENT
+            ),
         )
     }
 }
diff --git a/owncloudApp/src/main/res/layout/nav_coordinator_layout.xml b/owncloudApp/src/main/res/layout/nav_coordinator_layout.xml
@@ -50,7 +50,7 @@
         android:visibility="visible"
         app:itemIconTint="@color/primary_button_text_color"
         app:itemTextColor="@color/primary_button_text_color"
-        app:labelVisibilityMode="auto"
+        app:labelVisibilityMode="labeled"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"

diff --git a/owncloudApp/src/main/res/values/strings.xml b/owncloudApp/src/main/res/values/strings.xml
@@ -832,5 +832,7 @@
     <string name="audio_preview_label">Audio preview</string>
     <string name="details_label">Details</string>
     <string name="text_preview_label">Text preview</string>
+    <string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom bar</string>
+    <string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which section is selected on the bottom bar</string>
 
 </resources>