Fix state change for cmdGoTime state if provided value is a number #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in next version this change is included |
oweitman
added a commit
that referenced
this pull request
Aug 5, 2024
oweitman
added a commit
that referenced
this pull request
Aug 5, 2024
- improve cmdGoto handling by kairauer, close PR #74 - fix issues from adapter checker - integrate squeezenode lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi oweitman,
first of all: awesome ioBroker adapter!
The issue
I encountered one issue when using the ioBroker.simple-api adapter. This adapter allows to set any ioBroker state value with a HTTP API. Every squeezeboxrpc state I want to set via API works fine, except for cmdGoTime. This state is defined as "string", I assume thats because it can be set as a absolute time in seconds and a relative time like "+50" or "-50". When I set the absolute time in seconds via the HTTP API, that value is always casted to a number.
The solution
If the provided value is a number, we could simply cast this to a string. Then, the
state.val.trim()will not fail with a exception (trim()is not available for type number).