Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time exceeded flow for fip #230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add time exceeded flow for fip #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
433502d
Merge pull request #1 from ovn-org/main
ts170710 Sep 12, 2023
27d9424
Merge pull request #3 from ovn-org/main
ts170710 Dec 27, 2023
bc8fec9
Add time exceeded flow for fip
Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 38 additions & 0 deletions northd/northd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14680,6 +14680,42 @@ build_lrouter_arp_nd_for_datapath(struct ovn_datapath *od,
}
}

static void
build_time_exceeded_flow_for_dnat_and_snat(struct ovn_port *op,
struct hmap *lflows, struct ds *ip_ds,
struct ds *match, struct ds *actions,
const struct shash *meter_groups)
{
if (is_l3dgw_port(op)) {
for (int i = 0; i < op->od->nbr->n_nat; i++) {
ds_clear(match);
ds_clear(actions);
ds_clear(ip_ds);
struct ovn_nat *nat_entry = &op->od->nat_entries[i];
if (!strcmp(nat_entry->nb->type, "dnat_and_snat")) {
ds_put_format(match, "ip4.src == %s && ", nat_entry->nb->external_ip);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about IPv6? Why only on l3dgw ports? Why not on gw routers too?

ds_put_cstr(ip_ds, "ip4.dst <-> ip4.src");
ds_put_format(match,
"inport == %s && ip4 && "
"ip.ttl == {0, 1} && !ip.later_frag", op->json_key);
ds_put_format(actions,
"icmp4 {"
"eth.dst <-> eth.src; "
"icmp4.type = 11; /* Time exceeded */ "
"icmp4.code = 0; /* TTL exceeded in transit */ "
"%s ; ip.ttl = 254; "
"outport = %s; flags.loopback = 1; output; };",
ds_cstr(ip_ds), op->json_key);
ovn_lflow_add_with_hint__(lflows, op->od, S_ROUTER_IN_IP_INPUT,
30, ds_cstr(match), ds_cstr(actions), NULL,
copp_meter_get(COPP_ICMP4_ERR, op->od->nbr->copp,
meter_groups),
&op->nbrp->header_);
}
}
}
}

/* Logical router ingress table 3: IP Input for IPv4. */
static void
build_lrouter_ipv4_ip_input(struct ovn_port *op,
Expand Down Expand Up @@ -14730,6 +14766,8 @@ build_lrouter_ipv4_ip_input(struct ovn_port *op,

/* ICMP time exceeded */
struct ds ip_ds = DS_EMPTY_INITIALIZER;
build_time_exceeded_flow_for_dnat_and_snat(op, lflows, &ip_ds,
match, actions, meter_groups);
for (int i = 0; i < op->lrp_networks.n_ipv4_addrs; i++) {
ds_clear(match);
ds_clear(actions);
Expand Down