Always enforce checking all indexes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can be a case with ovsdb-server where we receive multiple creates in a row for an object that has different UUIDs, but the same named index. An example of this was seen with OVN and logical router ports, where we received a create for two of the same named ports. In this case the create should fail, and we should reconnect and reinitialize the cache. On the client side, we should always validate the cache population is legit, and if not, reconnect and try to re-init the cache. Signed-off-by: Tim Rozet <trozet@redhat.com>
|
@dave-tucker PTAL |
Pull Request Test Coverage Report for Build 1427588511
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a case with ovsdb-server where we receive multiple creates
in a row for an object that has different UUIDs, but the same named
index. An example of this was seen with OVN and logical router ports,
where we received a create for two of the same named ports. In this case
the create should fail, and we should reconnect and reinitialize the
cache.
On the client side, we should always validate the cache population is
legit, and if not, reconnect and try to re-init the cache.
Signed-off-by: Tim Rozet trozet@redhat.com