Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: return row uuids in List #252

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

flavio-fernandes
Copy link
Contributor

Provide uuid of rows when doing List. This is a pre-req for the
upcoming changes where transaction keeps a temporary db cache.

Pre-req for: #232

Signed-off-by: Flavio Fernandes flaviof@redhat.com

Provide uuid of rows when doing List. This is a pre-req for the
upcoming changes where transaction keeps a temporary db cache.

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1364172057

  • 1 of 11 (9.09%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 72.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cache/cache.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
cache/cache.go 1 70.99%
client/client.go 1 66.76%
Totals Coverage Status
Change from base Build 1343376136: 0.02%
Covered Lines: 4050
Relevant Lines: 5567

💛 - Coveralls

Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit a1499f2 into ovn-org:main Oct 20, 2021
@flavio-fernandes flavio-fernandes deleted the show_me_your_uuids branch October 27, 2021 20:26
@dave-tucker dave-tucker added the fix label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants