server: Handle uninitalized maps in mutateInsert #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1341553328
💛 - Coveralls |
Closed
jcaamano
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Being picky about names & descriptions, sorry!
I would change the existing test insert key value pairs on nil map to insert key value pairs on nil value
I guess it's worth it for me to change these names & descriptions since I was actually confused by it when I added the test.
A rework of ovn-org#237 Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
force-pushed
the
fix-server-again
branch
from
650c57e
to
bd416b3
Compare
|
@jcaamano don't be sorry. they were all good comments and I've just addressed them 😄 |
|
/lgtm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rework of #237
Signed-off-by: Dave Tucker dave@dtucker.co.uk