bindings: convert optional nil pointers to empty sets #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An optional field can be a nil pointer which represents, in this case, an empty set. Make NativeToOvs convert nil pointers to empty OvsSets so Update() operations that want to clear an optional field work. Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
amorenoz
added a commit
to amorenoz/ovs-flowmon
that referenced
this pull request
Oct 1, 2021
Use libovsdb to configure the IPFIX exporter DO NOT MERGE! TODO: This does not work because of a bug in libovsdb: ovn-org/libovsdb#231 Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
dave-tucker
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optional field can be a nil pointer which represents, in this case,
an empty set.
Make NativeToOvs convert nil pointers to empty OvsSets so Update()
operations that want to clear an optional field work.
Fixes: #230
Signed-off-by: Adrian Moreno amorenoz@redhat.com