Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-database fixes for client and server #224

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Sep 10, 2021

First commit fixes querying the secondary database (eg, _Server).

Second commit prevents multiple monitors from filtering out data intended for the other monitors.

Fixes: 349a5cc

@squeed @dave-tucker

Fixes querying the _Server database, for example.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@coveralls
Copy link

coveralls commented Sep 10, 2021

Pull Request Test Coverage Report for Build 1219884855

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 75.461%

Files with Coverage Reduction New Missed Lines %
client/client.go 2 72.1%
Totals Coverage Status
Change from base Build 1187061332: 0.2%
Covered Lines: 3435
Relevant Lines: 4552

💛 - Coveralls

Because each monitor filters the update and may remove rows from
the object, we need to copy it before filtering.

Specifically for a server with multiple databases, each with a
monitor, the second monitor would get an empty update because the
first monitor would have filtered out the data that didn't match
it's schema.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@dcbw dcbw changed the title client: transact against the requested database, not the primary Multi-database fixes for client and server Sep 10, 2021
dcbw added a commit to squeed/ovn-kubernetes that referenced this pull request Sep 10, 2021
Signed-off-by: Dan Williams <dcbw@redhat.com>
Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit ca80b79 into ovn-org:main Sep 10, 2021
@dave-tucker dave-tucker added the fix label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants