Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings: Add Optional UUID Handling to NativeToOvs #220

Merged
merged 1 commit into from
Aug 24, 2021
Merged

bindings: Add Optional UUID Handling to NativeToOvs #220

merged 1 commit into from
Aug 24, 2021

Conversation

dave-tucker
Copy link
Collaborator

Fixes: #216

@dave-tucker
bindings: Add Optional UUID Handling to NativeToOvs
8a7c7b0 
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1162458298

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 75.644%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ovsdb/bindings.go 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
ovsdb/bindings.go 1 74.93%
Totals Coverage Status
Change from base Build 1150093564: -0.001%
Covered Lines: 3317
Relevant Lines: 4385
💛 - Coveralls

alexanderConstantinescu
alexanderConstantinescu approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@alexanderConstantinescu alexanderConstantinescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests do not panic with this + seems good to me.

/lgtm

@alexanderConstantinescu alexanderConstantinescu mentioned this pull request Aug 24, 2021
Merged
@dave-tucker dave-tucker merged commit 9cab5b2 into ovn-org:main Aug 24, 2021
@alexanderConstantinescu alexanderConstantinescu mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu alexanderConstantinescu approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a model with a single valued optional referential value panics.
3 participants
@dave-tucker @coveralls @alexanderConstantinescu