client: Clean up RPC client on failed connect #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1150077443
💛 - Coveralls |
This issue was caught debugging reconnect failures. We attempt to reconnect as soon as the server disconnects, which allows us to open a socket, but there is no reply (listdbs fails) at this point, when we retry again, the rpcClient is not nil, so we assume we're already connected and don't return an error. This commit ensures that the rpcClient is set to nil if we fail to fully connect and adjusts our tests to perform a container restart instead of simply disconnecting the client to test the reconnect behaviour. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
force-pushed
the
fix-reconnect
branch
from
81c3916
to
2d41bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was caught debugging reconnect failures.
We attempt to reconnect as soon as the server disconnects, which allows
us to open a socket, but there is no reply (listdbs fails) at this
point, when we retry again, the rpcClient is not nil, so we assume we're
already connected and don't return an error.
This commit ensures that the rpcClient is set to nil if we fail to
fully connect and adjusts our tests to perform a container restart
instead of simply disconnecting the client to test the reconnect
behaviour.
Signed-off-by: Dave Tucker dave@dtucker.co.uk