Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opentelemetry support #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add opentelemetry support #189

wants to merge 1 commit into from

Conversation

dave-tucker
Copy link
Collaborator

@dave-tucker dave-tucker commented Jul 9, 2021 •
edited

  1. Added context.Context to most API methods for span propagation
  2. Spans are added to the parent (from context) when an API is called
  3. Simple cache metrics can be registered with cache.RegisterMetrics()
  4. Adds Docker Images for stress, print-schema and modelgen

Fixes: #146

Signed-off-by: Dave Tucker dave@dtucker.co.uk

@dave-tucker dave-tucker added this to the Future milestone Jul 9, 2021
@coveralls
Copy link

coveralls commented Jul 9, 2021 •
edited

Pull Request Test Coverage Report for Build 1333194463

  • 106 of 132 (80.3%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 73.185%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/transact.go 34 35 97.14%
client/client.go 23 26 88.46%
server/server.go 16 20 80.0%
cache/cache.go 10 28 35.71%
Files with Coverage Reduction New Missed Lines %
client/client.go 1 69.72%
Totals Coverage Status
Change from base Build 1321747633: 0.4%
Covered Lines: 4001
Relevant Lines: 5467
💛 - Coveralls

@dave-tucker dave-tucker modified the milestones: Future, 0.7.0 Jul 9, 2021
@dave-tucker dave-tucker mentioned this pull request Sep 14, 2021
Merged
@dave-tucker
Add opentelemetry support
08f8620 
1. Added context.Context to most API methods for span propagation
2. Spans are added to the parent (from context) when an API is called
3. Simple cache metrics can be registered with cache.RegisterMetrics()

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

OpenTelemetry Support
2 participants
@dave-tucker @coveralls