Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Support #146

Open
dave-tucker opened this issue Jun 7, 2021 · 1 comment · May be fixed by #189
Open

OpenTelemetry Support #146

dave-tucker opened this issue Jun 7, 2021 · 1 comment · May be fixed by #189
Assignees
Labels
Milestone

Comments

@dave-tucker
Copy link
Collaborator

dave-tucker commented Jun 7, 2021

I'm really keen on adding support for opentelemetry.io
This would require:

  1. Adding ctx context.Context to all clientAPI calls, which seems sensible for multiple reasons (i.e timeouts)
  2. Creating spans at useful points in the code, so we can see, for example, how long a given transaction takes
  3. We may also want to expose some metrics for the cache
@vtolstov
Copy link
Contributor

vtolstov commented Jun 7, 2021

nice

  1. Yes, useful also for some logging for example or pass additional info via context and extract it via span tags via some func observer
  2. I think that for each method we may create one span, and fill it via adding event to span so span - one operation that holds info for all processes like decode/encode/sent req/recv rsp.
  3. Yes, will be cool to be able to tune cache based on some metrics..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants