[Issue #820] Cannot convert token � (29333) to bytes: � for some model vocabularies when using llama.cpp #890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at solving issue #820 - RuntimeError: Cannot convert token � (29333) to bytes: �
With additional characters in the
gpt2_bytes_to_unicode()
map, I don't get errors anymore.However, it doesn't seem good to add ad-hoc characters like that. We should test on many more kinds of tokenizers.
Benchmarks pass:
![image](https://private-user-images.githubusercontent.com/6545903/329841026-b39de66a-eab2-4014-9434-a465bc15cff2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1OTMyMjgsIm5iZiI6MTcyNDU5MjkyOCwicGF0aCI6Ii82NTQ1OTAzLzMyOTg0MTAyNi1iMzlkZTY2YS1lYWIyLTQwMTQtOTQzNC1hNDY1YmMxNWNmZjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjVUMTMzNTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzQ1Y2U0MzVkNGVlOTg4MGYyNGE3NjUxNmI0OTNlM2E0MzVjNWE5YTliNmI1MWY5OGNjMDk3ZmQzZWE4Zjc2OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.oLdtLaC-fLA8VT7O7FkNfq6bYuytWw2qgIVisO4ZC7U)
Side note: Had to switch to Linux for development because of the
vllm
dependency, see their Requirements.