Fix Incorrect Finality Check in RegexGuide.get_next_state()
#884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #856
The issue was caused by the fact that in
RegexGuideself.final_statesincludes not just necessarily final states, but all **possibly final states, .In other words, in
mainif we get to a state which can legally complete (e.g.127.0.0.1), the current state will be returned forget_next_statefor any non-EOS token.127.0.0.11is a legal continuation, but because no state transition occurred, we could continue with127.0.0.123,127.0.0.1234,127.0.0.12345, etcThe correct check to determine whether a state is necessarily final and must produce an EOS next is
state not in self.states_to_token_maps.