Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Enum with only one element being ignored #721

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

isamu-isozaki
Copy link
Contributor

Fixes #720

@rlouf
Copy link
Member

rlouf commented Mar 2, 2024

Thank you for the quick fix! Would you mind adding a unit test for this?

@rlouf rlouf added bug structured generation Linked to structured generation labels Mar 2, 2024
@isamu-isozaki
Copy link
Contributor Author

For sure! Let me figure that out

tests/fsm/test_json_schema.py Outdated Show resolved Hide resolved
@rlouf rlouf merged commit 88dc97c into outlines-dev:main Mar 2, 2024
5 checks passed
@rlouf
Copy link
Member

rlouf commented Mar 2, 2024

Thank you for contributing!

@isamu-isozaki
Copy link
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug structured generation Linked to structured generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum for only one element gets invalid regex
2 participants