Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize and Add Release-Push Workflow #688

Merged
merged 12 commits into from
Feb 21, 2024

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Feb 20, 2024

Fixes #555

Need some setup on your end please @rlouf:

  • Let me know the outlines official docker repo URL so I can update release.yml and docs
  • Configure the DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets on GitHub in an environment named "release".

TODO:

Andrew Lapp added 5 commits February 20, 2024 05:08
temporarily remove pypi step

fix spacing in runner

include necessary docker components

remove default model

add docker build to contribute guide

include . in context

try v2

try immediately after checkout

try this

BUILDKIT_CONTEXT_KEEP_GIT_DIR

try version downgrade

try this

try this

try this

include pypi
@rlouf
Copy link
Member

rlouf commented Feb 20, 2024

Thanks! Let's add a section in the docs' serve page, and maybe on the README as well?

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 20, 2024

Thanks! Let's add a section in the docs' serve page, and maybe on the README as well?

Great idea. Added to the docs with lapp0/outlines-serve as a placeholder for the official repo.

@rlouf
Copy link
Member

rlouf commented Feb 20, 2024

The repository: https://hub.docker.com/repository/docker/outlinesdev/outlines/general. Secrets should be properly configured in the new "release" environment.

docs/quickstart.md Outdated Show resolved Hide resolved
@lapp0 lapp0 marked this pull request as ready for review February 21, 2024 08:55
@rlouf
Copy link
Member

rlouf commented Feb 21, 2024

This looks good to me. Is it ready on your end?

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 21, 2024

@rlouf Build was successful on https://github.com/lapp0/outlines and the resulting docker container worked for me. Docs seem fine. Only question is whether it'll work with this repos configuration

We either can either release a new version to check if it works with your GitHub configuration, or I can add a workflow_dispatch to release.yml (https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow) so you can run the workflow first before releasing.

@rlouf
Copy link
Member

rlouf commented Feb 21, 2024

Good idea for the dispatch! It can be a real pain to debug workflows, even more if we need to cut a new release every time there's a failure.

@rlouf rlouf added enhancement vLLM Things involving vLLM support labels Feb 21, 2024
@rlouf
Copy link
Member

rlouf commented Feb 21, 2024

Thanks! It would be less error-prone to have two separate release-pypi.yml and release-dockerhub.yml files instead of branching logic in the yaml. Also, the PyPi token is not in the release environment.

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 21, 2024

https://github.com/outlines-dev/outlines/actions/workflows/release.yml will have a "Run Workflow" button once this is in main. It will deploy to Docker Hub, but not perform any other actions (no PyPi).

Example run via workflow_dispatch https://github.com/lapp0/outlines/actions/runs/7992044914/job/21824662684

Thanks! It would be less error-prone to have two separate release-pypi.yml and release-dockerhub.yml files instead of branching logic in the yaml.

True

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 21, 2024

Oops, looks like you already implemented. Please push yours once more.

@rlouf
Copy link
Member

rlouf commented Feb 21, 2024

We did the same thing. Let's merge and see

@rlouf rlouf merged commit 26d9f0c into outlines-dev:main Feb 21, 2024
5 checks passed
@rlouf
Copy link
Member

rlouf commented Feb 21, 2024

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 21, 2024

@rlouf My push was missing a checkout step, I don't expect it to pass for pypi.

Edit: the current failure is due to it missing

036693b#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R35

Sorry, I should have been more clear that my push wasn't ready and marked as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vLLM Things involving vLLM support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official Docker Builds
2 participants