Ensure Ancestors on Correct Device During Sampling #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You would need to do this for every sampling method |
|
Good catch. Beam and greedy needs changes as well. Smoke tested, can confirm for all 3 samplers the device is set correctly: |
rlouf
reviewed
Feb 12, 2024
| @@ -66,7 +66,9 @@ def __call__( | |||
| logprobs = torch.nn.functional.log_softmax(next_token_logits, dim=-1) | |||
| next_token_ids = torch.argmax(logprobs, dim=-1, keepdim=True) | |||
|
|
|||
| ancestors = torch.arange(next_token_logits.shape[0]) | |||
| ancestors = torch.arange( | |||
| next_token_logits.shape[0], device=next_token_logits.device | |||
There was a problem hiding this comment.
nit: let's be consistent across samplers and use next_token_logits for each sampler :)
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649