Allow JSON Schema Constraining to a Single Whitespace #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be cleaner to allow users to pass the regex for the whitespace directly and default to the current |
rlouf
reviewed
Feb 9, 2024
rlouf
reviewed
Feb 9, 2024
|
Looks good. Could we add something in the documentation using an admonition since this is a topic that comes up often in issues? |
rlouf
force-pushed
the
allow-single-whitespace-json
branch
from
009a1d7
to
06741f8
Compare
rlouf
force-pushed
the
allow-single-whitespace-json
branch
from
06741f8
to
456d561
Compare
|
I fixed the merge conflicts and added documentation. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling
multiple_wsargument in JSON constrained generation. Results in a maximum of one consecutive syntactic whitespace (no impact on string literals).Fixes #624