Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump torch and transformers versions #613

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Feb 5, 2024

  • Confirming the issue with torch reproduces in CI.
    • torch 2.0.1 resulted in test failure

In torch>=1.13.1,!=2.0.*, the OSError described in #568 is resolved.

fixes #568

We also should upgrade outlines version, as you cannot directly install outlines[serve] due to the dependency conflict between vllm==0.3.0 (requires transformers>=4.37.0) and outlines==0.0.26 (requires transfomers==4.36.2)

@lapp0 lapp0 changed the title Unpin Transformers Unpin Transformers, Pin Torch Feb 5, 2024
@lapp0 lapp0 changed the title Unpin Transformers, Pin Torch Pin Torch, Allow Outlines to Use New Transformers Feb 5, 2024
@rlouf
Copy link
Member

rlouf commented Feb 6, 2024

Thank you !

In torch>=1.13.1,!=2.0.*, the OSError described in #568 is resolved.

Any way we can simplify this by forcing torch >= X?

We also should upgrade outlines version, as you cannot directly install outlines[serve] due to the dependency conflict between vllm==0.3.0 (requires transformers>=4.37.0) and outlines==0.0.26 (requires transfomers==4.36.2)

You mean cutting a new release once this has been merged?

@lapp0
Copy link
Collaborator Author

lapp0 commented Feb 6, 2024

Any way we can simplify this by forcing torch >= X?

Will do.

You mean cutting a new release once this has been merged?

Yep, due to the dependency conflict pip is resolving outlines[serve] to 0.0.19

Fresh venv:

pip3 install "outlines[serve]" -q

pip3 freeze | grep -P "(outlines|vllm)"
outlines==0.0.19
vllm==0.3.0
pip3 install "outlines[serve]==0.0.26"
ERROR: Cannot install outlines[serve]==0.0.26 and vllm==0.3.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    outlines[serve] 0.0.26 depends on transformers==4.36.2
    vllm 0.3.0 depends on transformers>=4.37.0

@rlouf rlouf changed the title Pin Torch, Allow Outlines to Use New Transformers Bump torch and transformers versions Feb 6, 2024
@rlouf rlouf merged commit 1626cea into outlines-dev:main Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transformers 4.37.0 Breaks Outlines
2 participants