introduce WHITESPACE regex constant #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very good idea, we might want to be able to pass that as an argument in the near future as well, from our internal experiments it looks like it has a substantial effect on the generation. |
rlouf
added
structured generation
|
It looks like a warning that’s raised in |
|
+1 for changing outlines/fsm/json_schema.py from whitespace = r"[\n ]* to whitespace = r"[\n ]?" (or just deleting whitespace altogether) to avoid endless generation of new lines |
rlouf
force-pushed
the
patch-2
branch
2 times, most recently
from
106717c
to
499d23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To harmonize with other regexes that are already in constants.
This will also allow to do monkey patching of this regex, to do experiments related to #484