Reset lark package in test_parsing.py
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapp0
changed the title
test_parsing.py Affecting State of Larktest_parsing.py Affecting Global State, Breaking Tests
|
Please make your PR titles a description of the changes and/or what's technically being addressed. |
brandonwillard
changed the title
test_parsing.py Affecting Global State, Breaking Testslark package in test_parsing.py
Done! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
test_grammars.pyfails iftest_parsing.pyis run first. This results in tests failing in #539This changeset ensures that
test_parsing.pyis isolated and doesn't impact other tests.Previously running the tests would impact
lark.lark.LarkOptions._defaults(A class variable, not an instance variable), now the impact is erased viaimportlib.reload(lark.lark)