Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to documentation and README #547

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Improvements to documentation and README #547

merged 2 commits into from
Jan 18, 2024

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Jan 17, 2024

No description provided.

@rlouf rlouf added enhancement documentation Linked to documentation and examples labels Jan 17, 2024
@rlouf rlouf merged commit 65ed0f7 into main Jan 18, 2024
5 checks passed
@rlouf rlouf deleted the documentation-vllm branch January 18, 2024 22:29
@viktor-ferenczi
Copy link

The doc is still wrong:

  • This command installs vLLM 0.1.2 for me, not the latest 0.2.7: pip install outlines[serve]
  • The version condition needs to be quoted, otherwise the > works as a redirect to file: pip install pydantic>=2.0

@viktor-ferenczi
Copy link

viktor-ferenczi commented Jan 21, 2024

After uninstalling vllm (0.1.2), upgrading pydantic, installing vllm 0.2.7 and upgrading outlines (the command in the doc installed 0.0.19) I get this error:

vllm 0.2.7 requires pydantic==1.10.13, but you have pydantic 2.5.3 which is incompatible.
Successfully installed outlines-0.0.24 pydantic-2.5.3

However, vLLM works with outlines.serve.server in this state nevertheless. Maybe the vLLM dependencies are wrong.

@rlouf
Copy link
Member Author

rlouf commented Jan 22, 2024

vLLM just bumped the Pydantic version requirement: vllm-project/vllm#2531

@viktor-ferenczi
Copy link

What about the other issue, that pip install outlines[serve] installs old vLLM (0.1.2) and outline (0.0.19)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Linked to documentation and examples enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants