Allow to generate several samples for each prompt #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
restore-multiple-samples
branch
6 times, most recently
from
f558105
to
5cebac7
Compare
rlouf
commented
Jan 21, 2024
rlouf
force-pushed
the
restore-multiple-samples
branch
5 times, most recently
from
a1f9a8a
to
88c8bc6
Compare
rlouf
force-pushed
the
restore-multiple-samples
branch
3 times, most recently
from
19f8eb5
to
4358032
Compare
lapp0
reviewed
Jan 24, 2024
There was a problem hiding this comment.
I'm still learning the outlines/generate/ side of the code-base. If there are any components you would like test cases for, that would help me learn :)
IMHO we shouldn't reshape at all. Users should expect an array of results with the same length as their input prompts. A shape-agnostic decoder should be a final step so we aren't required to convert to decodable array and back again in multiple places.
rlouf
commented
Jan 24, 2024
rlouf
force-pushed
the
restore-multiple-samples
branch
from
4358032
to
536cc7d
Compare
rlouf
force-pushed
the
restore-multiple-samples
branch
from
4035150
to
6989e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416
TODO
torch.repeat_interleaveso samples of the same sequence in a batch are contiguous (easier for beam search)Questions
(num_samples * batch_size, num_tokens), and reshape inSequenceGenerator? Reshaping in the generator makes the latter much more complex. We could also not reshape at all, and let the user do it manually, which will simplify chained calls in the future.