Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates chess cookbook example with Phi-2 and adds omitted code. #521

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Updates chess cookbook example with Phi-2 and adds omitted code. #521

merged 2 commits into from
Jan 10, 2024

Conversation

kgourgou
Copy link
Contributor

Hello,

This was a fun example in the cookbook, but there were some elements missing, e.g., model was referenced in the code, but not defined anywhere, board_state was set to be the model, etc.

I updated the example to use the smaller Phi-2 (which actually plays terrible, but otherwise longer chess) and added the code needed so that the example can run.

@rlouf
Copy link
Member

rlouf commented Jan 10, 2024

Thank you! You will have to run pre-commit --run all locally to fix the styling issues

@kgourgou
Copy link
Contributor Author

Done.

@rlouf rlouf merged commit 1916392 into outlines-dev:main Jan 10, 2024
5 checks passed
@rlouf
Copy link
Member

rlouf commented Jan 10, 2024

Thank you for updating the example, much appreciated!

@rlouf rlouf added the documentation Linked to documentation and examples label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Linked to documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants