Add CFG to vllm serving #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
added
structured generation
rlouf
reviewed
Jan 11, 2024
outlines/serve/serve.py
Outdated
| @@ -122,6 +127,8 @@ async def stream_results() -> AsyncGenerator[bytes, None]: | |||
| # Sets default for the model (`facebook/opt-125m`) | |||
| engine = AsyncLLMEngine.from_engine_args(engine_args) | |||
|
|
|||
| _adapt_tokenizer(engine.engine.tokenizer) | |||
There was a problem hiding this comment.
Why are you calling this function here? The result is not used.
There was a problem hiding this comment.
The tokenizer is changed inside the function anyways. I now assigned it to the tokenizer though.
There was a problem hiding this comment.
Ah makes sense. It's not needed however as vLLM handles tokenisation on its end during encoding/decoding.
There was a problem hiding this comment.
It's needed because in here
Line 345 in fde61a8
Also I just realized that this change makes a breaking change to the library. If it's fine by the project directors its fine, if not we might need a change.
for example we can call
_adapt_tokenizer inside __init__ functions of the logit processors
mory91
force-pushed
the
vllm-cfg
branch
2 times, most recently
from
012a0e9
to
281c0af
Compare
|
Thank you for your contributions! I added some documentation before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request adds support for CFG in vllm serving.