Cache creation of states_token_mapping in the __init__ of RegexFSM #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I wonder if using |
|
I think it makes the code much cleaner in that case (and does not change the use of |
Closed
lapp0
reviewed
Jan 6, 2024
|
Good work! |
rlouf
reviewed
Jan 8, 2024
rlouf
reviewed
Jan 8, 2024
rlouf
force-pushed
the
cache_regexfsm_init
branch
from
542d30b
to
6017d30
Compare
rlouf
approved these changes
Jan 11, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aimed at talking about the resolution of issue #483
I tried to do it in a way that requires as few modification to existing functions as possible. It implies modifying the type of several variables for them to be cacheable/json-serializeable. It looks a bit awkward and leads to the initialization of the RegexFSM instance taking a bit more time when not cached because of the type conversions, but I thought that could be the start of further discussions on the topic