Remove the symbolic structure #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
simplify_codebase
branch
2 times, most recently
from
50dc834
to
a4389e6
Compare
The logic in the `outlines.text.completion` function is obscured by the necessity to parse model paths and initialize models. We thus create a function that returns the model that corresponds to the input path if such model exists.
rlouf
force-pushed
the
simplify_codebase
branch
2 times, most recently
from
1be5575
to
6731deb
Compare
rlouf
force-pushed
the
simplify_codebase
branch
9 times, most recently
from
33be9f3
to
890bb98
Compare
Jinja2 does not fail when the user calls for an attribute that does not exist, and replaces the template variable with an empty string. This behavior is error-prone in this context. We thus ask Jinja2 explicity to raise an exception in these cases.
rlouf
force-pushed
the
simplify_codebase
branch
from
890bb98
to
2909871
Compare
rlouf
force-pushed
the
simplify_codebase
branch
from
2909871
to
54a0a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the new proposal in https://docs.google.com/document/d/1OhFDi9XvJEkopPZ6zwSIzzOPAQ-9o64HhhJZXpKlRos/edit?resourcekey=0-6XWD2UYq465H7ZKLOmQd-A#heading=h.c0uts5ftkk58
joblibAlso closes #49. Closes #51.