Add optional api_key parameter
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable when no key is supplied
rlouf
changed the title
api_key parameter
rlouf
reviewed
Nov 13, 2023
| def __init__( | ||
| self, | ||
| model_name: str, | ||
| api_key: Optional[str] = os.getenv("OPENAI_API_KEY"), |
There was a problem hiding this comment.
Optional is equivalent to X | None in Python. Since a default value is provided this should not be typed as Optional.
There was a problem hiding this comment.
Alright, the mypy precommit hook was complaining and that solved it. Will get it fixed correctly.
There was a problem hiding this comment.
Ah right, it's because os.getenv can return None. Sorry bit new to python.
rlouf
reviewed
Nov 13, 2023
outlines/models/openai.py
Outdated
| ) -> Union[List[str], str]: | ||
| """Generate a sequence that must be one of many options. | ||
| ` | ||
| .. warning:: |
There was a problem hiding this comment.
I think formatter commit hook did this
There was a problem hiding this comment.
Hmm doesn't mess with the formatting now.
|
Thank you for contributing! I have a couple of comments that will need to be addressed before merging. |
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to supply an optional Openai API key, this is useful for services that allow users to supply their own API keys (like web services).