Remove approximate guided generation methods for OpenAI APIs #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
remove-openai-guided
branch
3 times, most recently
from
2274b28
to
1b36b51
Compare
The `type` guided-generation method for the OpenAI API is not correct since we cannot bias more than 300 tokens at every step. It is better to remove these features than misguide users.
rlouf
force-pushed
the
remove-openai-guided
branch
from
1b36b51
to
99c0498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typeguided-generation method for the OpenAI API is not correct since we cannot bias more than 300 tokens at every step. It is better to remove these features than misguide users.Closes #347. Closes #141. Closes #144.
Continuationto warn users these models can't be used with guided generationtransformers