Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation Inconsistency in Joke Class Example #356

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

MelodiousThonk
Copy link
Contributor

Fix Documentation Inconsistency in Joke Class Example

This pull request addresses an inconsistency found in the Joke class example within the README file of the outlines repository. The changes ensure that the inline documentation correctly reflects the actual output format.

Changes Made

  • Updated the Joke class definition to use Field descriptors for joke and explanation attributes.

Issue Identified

The previous version of the README included an example where the Joke class did not use Field descriptors, leading to a discrepancy between the class definition and the output format described in the comments. This could potentially cause confusion for users trying to understand the expected behavior of the joke_ppt function.

Resolution

By introducing Field descriptors in the Joke class, the documentation now accurately reflects the structure and output format of the joke_ppt function, enhancing clarity and correctness.

I believe these updates will make the documentation more accurate and helpful for users. Your feedback and further suggestions are always welcome.

Thank you for considering this pull request.

@rlouf rlouf merged commit 4b653d5 into outlines-dev:main Nov 12, 2023
5 checks passed
@rlouf
Copy link
Member

rlouf commented Nov 12, 2023

Thank you for contributing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants