Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math error in sampling example #334

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

mwesthelle
Copy link
Contributor

If I'm 6 and my sister is half my age, this means she's 3. 64 years later, when I'm 70, my sister is going to be 67, as her age isn't always my age divided by 2.

@rlouf
Copy link
Member

rlouf commented Nov 6, 2023

Thank you for the PR! Unfortunately this is the model's answer and I don't think we should correct it?

@mwesthelle
Copy link
Contributor Author

Thank you for the PR! Unfortunately this is the model's answer and I don't think we should correct it?

This is not the model's output, this is markdown text in the notebook :)

@brandonwillard
Copy link
Contributor

Thank you for the PR! Unfortunately this is the model's answer and I don't think we should correct it?

This is not the model's output, this is markdown text in the notebook :)

Yeah, it looks like a mistake in an expository statement about the correct answer.

@rlouf rlouf merged commit 3667e04 into outlines-dev:main Nov 6, 2023
5 checks passed
@mwesthelle mwesthelle deleted the patch-1 branch November 6, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants