Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos and language #254

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Fix some typos and language #254

merged 4 commits into from
Aug 21, 2023

Conversation

jrysana
Copy link
Contributor

@jrysana jrysana commented Aug 20, 2023 •
edited

Hey, some small things I saw here, feel free to cherry-pick/discuss.

  • Fixes a typo in the file outlines/models/__init__.py
  • Fixes a typo in the file outlines/models/hf_transformers.py
  • Fixes mismatched language in the outlines/vectors/retrieval.py file between the k argument and the phrase top_n
  • Uses "Hugging Face" instead of "HuggingFace" outside of code, in line with that brand.

@jrysana jrysana marked this pull request as draft August 20, 2023 21:47
@jrysana jrysana marked this pull request as ready for review August 20, 2023 21:59
@jrysana jrysana changed the title Fix typo in models index Fix some typos and language Aug 20, 2023
brandonwillard
brandonwillard approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rlouf rlouf merged commit 5a1ff6e into outlines-dev:main Aug 21, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonwillard brandonwillard brandonwillard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrysana @brandonwillard @rlouf