Generate a choice between different strings #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
add-choice-generation-method
branch
from
9228675
to
c1d7a61
Compare
| for i, vocab_string in enumerate(vocabulary): | ||
| if vocab_string == final_state_string: | ||
| final_state_string_idx = i | ||
|
|
||
| for end_idx, state_seq in find_partial_matches(fsm, vocab_string): | ||
| if partial_match_filter(vocab_string, end_idx, state_seq): | ||
| terminal_possible_paths[state_seq[0]].add(state_seq[-1]) |
There was a problem hiding this comment.
Whether or not the last state is a final/accept state of the FSM will depend on partial_match_filter, no? We might need extra handling for this, or we could track these things in that filter function, after adding the symbol name as an argument, of course.
There was a problem hiding this comment.
The check would fail if the combination of the vocabulary and partial_match_filter didn't allow to reach a final state, no? Isn't that the desired behaviour?
rlouf
commented
Jul 15, 2023
rlouf
force-pushed
the
add-choice-generation-method
branch
3 times, most recently
from
a36c5c2
to
b29a601
Compare
If the vocabulary does not allow to transition from the FSM's initial state to one of its terminal paths it will be impossible to generate a sequence that matches the input regex. We therefore raise an exception when no such transition exists.
rlouf
force-pushed
the
add-choice-generation-method
branch
from
b29a601
to
a3f7b9e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152. I use the
Regexgeneration method using a(choice_1|choice_2|...|choice_n)regex. This method is equivalent to rejection sampling: draw a token and discard it if it is not on a path that generates either of the choices.An alternative implementation would be to tokenize the choices, do a forward pass through the model with each and sample from the resulting categorical distribution. However, some strings can be built from different combinations of tokens and we would only be considering one for each stopping sequence.
Unsurprisingly, the check to verify that a sequence can be generated with the vocabulary added in #175 fails. We fix this by checking whether we can build terminal paths with the vocabulary. Closes #184.