Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overview document and a type hint #183

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mlelarge
Copy link
Contributor

Very nice work! Thanks!
Just started playing with it and got an error with the Hello World example in the documentation. This small modification fixed the issue for me.

Another remark: experimenting in a Jupyter notebook does not work because of a pb with asynchio, see https://pypi.org/project/nest-asyncio/
The solution proposed there worked for me:

import nest_asyncio
nest_asyncio.apply()

It would probably be nice to refer to it in the documentation.

I hope this helps.
Best,
Marc

@brandonwillard brandonwillard changed the title bug with Hello World Fix overview document and a type hint Jul 12, 2023
@brandonwillard brandonwillard added bug documentation Linked to documentation and examples labels Jul 12, 2023
outlines/text/prompts.py Outdated Show resolved Hide resolved
@rlouf
Copy link
Member

rlouf commented Jul 13, 2023

Thank you for contributing @mlelarge!

@rlouf rlouf merged commit 0bdcc56 into outlines-dev:main Jul 13, 2023
4 checks passed
@mlelarge mlelarge deleted the bug_hello_world branch July 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Linked to documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants