Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_name as an additional optional parameter for azure open ai client. #824

Closed
HerrIvan opened this issue Apr 17, 2024 · 1 comment
Closed

Comments

@HerrIvan
Copy link
Contributor

Presentation of the new feature

The Azure OpenAI documentation explains that model instances have two properties: deployment_name and model_name. While model_name refers to the well-known OpenAI models (e.g., GPT-4, GPT-3.5-turbo), deployment_name specifies a specific instance within an Azure tenant. There can be cases where these names differ, such as deploying multiple versions of the same model. If these names do not match, the code may attempt to select a tokenizer based on the deployment_name and fail. Allowing model_name to be passed as an optional parameter would enable the correct selection of the tokenizer, avoiding errors.

Where does it fit in Outlines?

Since Azure OpenAI is already integrated, fixing this costs nothing.

Are you willing to open a PR?

Yes I will, it takes like 20 ASCII characters max to fix this while being backwards compatible.

@HerrIvan
Copy link
Contributor Author

Perfect, thanks Rémi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant