Added option to set docker max log size #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fastlorenzo <git@bernardi.be>
github-actions
bot
added
elkserver
|
I wan't this in there asap. Seems a bugfix that is usefull straight away with minimal risk. |
|
Personally Im not really happy with the chosen logging driver: json. I would prefer to use "log-driver": "local" as these logs are mainly used for troubleshooting by humans. Imho json spits out too much gibberish. log-driver local just spits out txt based log files. Call me oldskool, but I prefer that :-) OK to keep this json logging in for now. Ill make a PR when this really start to bother me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151