Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/Image Gallery Tests #244

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Tech/Image Gallery Tests #244

merged 4 commits into from
Nov 3, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Nov 3, 2022

Unit tests around fetching images for the image gallery screen

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

APK Size: 2.01 MB

- fixes wrong page key being used to cancel previous
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #244 (6492afe) into main (40534bc) will increase coverage by 1.30%.
The diff coverage is 82.14%.

❗ Current head 6492afe differs from pull request most recent head b1c5481. Consider uploading reports for the commit b1c5481 to get more accurate results

@@             Coverage Diff              @@
##               main     #244      +/-   ##
============================================
+ Coverage     59.68%   60.98%   +1.30%     
- Complexity      570      581      +11     
============================================
  Files           243      245       +2     
  Lines          6126     6147      +21     
  Branches        736      735       -1     
============================================
+ Hits           3656     3749      +93     
+ Misses         2138     2060      -78     
- Partials        332      338       +6     
Impacted Files Coverage Δ
.../st/messenger/gallery/state/ImageGalleryReducer.kt 83.33% <ø> (+53.33%) ⬆️
...tlin/app/dapk/st/core/ContentResolverExtensions.kt 40.00% <40.00%> (ø)
...k/st/messenger/gallery/FetchMediaFoldersUseCase.kt 92.85% <94.11%> (+92.85%) ⬆️
...app/dapk/st/messenger/gallery/FetchMediaUseCase.kt 97.50% <100.00%> (+97.50%) ⬆️
...app/dapk/st/messenger/gallery/MediaUriAvoidance.kt 100.00% <100.00%> (ø)
.../dapk/st/messenger/gallery/MediaStoreExtensions.kt 0.00% <0.00%> (ø)
...c/main/kotlin/app/dapk/st/core/page/PageReducer.kt 57.89% <0.00%> (+2.63%) ⬆️
...pk/st/messenger/gallery/state/ImageGalleryState.kt 100.00% <0.00%> (+25.00%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ouchadam ouchadam merged commit 78a4cbd into main Nov 3, 2022
@ouchadam ouchadam deleted the tech/gallery-tests branch November 3, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant