Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/redux pattern #233

Merged
merged 10 commits into from
Nov 1, 2022
Merged

Tech/redux pattern #233

merged 10 commits into from
Nov 1, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Oct 31, 2022

Starts the refactor away from direct state/viewmodel usages in favour of a state management, a hybrid of redux and mobius.

Makes testing the state changes much simpler

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

APK Size: 2 MB

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #233 (b9dda51) into main (5873047) will increase coverage by 0.86%.
The diff coverage is 62.33%.

@@             Coverage Diff              @@
##               main     #233      +/-   ##
============================================
+ Coverage     58.63%   59.50%   +0.86%     
+ Complexity      589      583       -6     
============================================
  Files           231      237       +6     
  Lines          5925     6015      +90     
  Branches        702      706       +4     
============================================
+ Hits           3474     3579     +105     
+ Misses         2143     2118      -25     
- Partials        308      318      +10     
Impacted Files Coverage Δ
...e/src/main/kotlin/app/dapk/st/engine/ChatEngine.kt 80.00% <ø> (ø)
core/src/main/kotlin/app/dapk/st/core/JobBag.kt 0.00% <0.00%> (ø)
...main/kotlin/app/dapk/st/core/ActivityExtensions.kt 0.00% <0.00%> (ø)
...src/main/kotlin/app/dapk/st/core/StateViewModel.kt 0.00% <0.00%> (ø)
...main/kotlin/app/dapk/st/viewmodel/DapkViewModel.kt 77.77% <ø> (ø)
...in/kotlin/app/dapk/st/directory/ShortcutHandler.kt 0.00% <0.00%> (ø)
...tlin/app/dapk/st/directory/state/DirectoryState.kt 0.00% <ø> (ø)
.../src/main/kotlin/app/dapk/st/home/HomeViewModel.kt 0.00% <0.00%> (ø)
...in/kotlin/app/dapk/st/messenger/MessengerScreen.kt 0.00% <ø> (ø)
...tlin/app/dapk/st/messenger/state/MessengerState.kt 100.00% <ø> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ouchadam ouchadam merged commit 72fa795 into main Nov 1, 2022
@ouchadam ouchadam deleted the tech/redux-pattern branch November 1, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant