Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crash when logging in or opening profile when no profile has been set #177

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Oct 1, 2022

Fixes #176

allowing the profile call to continue when receiving a 404 instead of crashing

  • This case is known by the spec for when a profile doesn't exist yet
  • 403s still crash as fetching your own profile information should never result in access denied

… crashing

- this case is known by the spec for when a profile doesn't exist yet
- 403s still crash as fetching your own profile information should never result in access denied
@ouchadam ouchadam added the bug Something isn't working label Oct 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

APK Size: 1.84 MB

@ouchadam ouchadam merged commit 7d9046e into main Oct 1, 2022
@ouchadam ouchadam deleted the crash/loading-account-without-profile branch October 1, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crash] When /_matrix/client/v3/profile/{userId} returns non 200 response
1 participant