Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v flag to regexp/no-useless-character-class rule #593

Merged
merged 10 commits into from
Sep 21, 2023

Conversation

ota-meshi
Copy link
Owner

related to #545

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2023

🦋 Changeset detected

Latest commit: 699695e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-regexp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi marked this pull request as draft September 10, 2023 06:58
@ota-meshi ota-meshi changed the title Improve regexp/no-useless-character-class rule auto-fix to supports nested character classes Add support for v flag to regexp/no-useless-character-class rule Sep 10, 2023
@ota-meshi ota-meshi marked this pull request as ready for review September 10, 2023 07:06
@ota-meshi ota-meshi marked this pull request as draft September 10, 2023 07:37
@ota-meshi ota-meshi marked this pull request as ready for review September 10, 2023 11:56
@RunDevelopment
Copy link
Collaborator

This currently doesn't handle inlining empty character classes correctly. E.g. /[[]^]/v and /[&[]&]/v.

@ota-meshi
Copy link
Owner Author

Thank you for checking this PR. I fixed bugs 😃

@RunDevelopment RunDevelopment merged commit b0f6396 into master Sep 21, 2023
5 checks passed
@RunDevelopment RunDevelopment deleted the no-useless-character-class branch September 21, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants