-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve regexp/sort-alternatives
rule to add support for string alternatives and v flag
#587
Conversation
…junctions and v flag
🦋 Changeset detectedLatest commit: b0ddd9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lib/rules/sort-alternatives.ts
Outdated
} else { | ||
const words: ReadonlyWord[] = [ | ||
...(us.chars.isEmpty ? [] : [[us.chars.ranges[0].min]]), | ||
...us.accept.words, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the same fix to this PR. (But there may be conflicts)
@RunDevelopment I fixed getLexicographicallySmallestInConcatenation a little. Could you check if it is the correct fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ota-meshi and sorry for the delay!
close #572